Migrate optimize product test to integration test in Delta Lake

trinodb · Oct 3, 2024 · b9178b1 · b9178b1
1 parent ddc699d
commit b9178b1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 29 deletions.
diff --git a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
@@ -1010,6 +1010,9 @@ public void testWritesToTableWithIdentityColumnFails()
         assertQueryFails(
                 "MERGE INTO " + tableName + " t USING " + tableName + " s ON (t.a = s.a) WHEN MATCHED THEN UPDATE SET a = 1",
                 "Writing to tables with identity columns is not supported");
+        assertQueryFails(
+                "ALTER TABLE " + tableName + " EXECUTE optimize",
+                "Writing to tables with identity columns is not supported");
     }
 
     @Test

diff --git a/.../main/java/io/trino/tests/product/deltalake/TestDeltaLakeIdentityColumnCompatibility.java b/.../main/java/io/trino/tests/product/deltalake/TestDeltaLakeIdentityColumnCompatibility.java
@@ -184,35 +184,6 @@ public void testVacuumProcedureWithIdentityColumn()
         }
     }
 
-    @Test(groups = {DELTA_LAKE_DATABRICKS_104, PROFILE_SPECIFIC_TESTS})
-    @Flaky(issue = DATABRICKS_COMMUNICATION_FAILURE_ISSUE, match = DATABRICKS_COMMUNICATION_FAILURE_MATCH)
-    public void testOptimizeProcedureWithIdentityColumn()
-    {
-        String tableName = "test_optimize_identity_column_" + randomNameSuffix();
-
-        onDelta().executeQuery("CREATE TABLE default." + tableName +
-                "(data INT, col_identity BIGINT GENERATED ALWAYS AS IDENTITY)" +
-                "USING DELTA " +
-                "LOCATION 's3://" + bucketName + "/" + "databricks-compatibility-test-" + tableName + "'");
-        try {
-            onDelta().executeQuery("INSERT INTO default." + tableName + " (data) VALUES 10");
-            onDelta().executeQuery("INSERT INTO default." + tableName + " (data) VALUES 20");
-
-            onTrino().executeQuery("ALTER TABLE delta.default." + tableName + " EXECUTE OPTIMIZE");
-
-            assertThat((String) onDelta().executeQuery("SHOW CREATE TABLE default." + tableName).getOnlyValue())
-                    .contains("col_identity BIGINT GENERATED ALWAYS AS IDENTITY");
-
-            assertThat(onTrino().executeQuery("SELECT * FROM delta.default." + tableName))
-                    .containsOnly(row(10, 1), row(20, 2));
-            assertThat(onDelta().executeQuery("SELECT * FROM default." + tableName))
-                    .containsOnly(row(10, 1), row(20, 2));
-        }
-        finally {
-            dropDeltaTableWithRetry("default." + tableName);
-        }
-    }
-
     @Test(groups = {DELTA_LAKE_DATABRICKS_104, PROFILE_SPECIFIC_TESTS})
     @Flaky(issue = DATABRICKS_COMMUNICATION_FAILURE_ISSUE, match = DATABRICKS_COMMUNICATION_FAILURE_MATCH)
     public void testIdentityColumnCheckpointInterval()