Make sure expression type does not change after processing with rule

trinodb · Jun 14, 2024 · de6ba02 · de6ba02
1 parent 5e2f4bb
commit de6ba02
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/sql/ir/optimizer/IrExpressionOptimizer.java b/core/trino-main/src/main/java/io/trino/sql/ir/optimizer/IrExpressionOptimizer.java
@@ -73,6 +73,8 @@
 import java.util.Map;
 import java.util.Optional;
 
+import static com.google.common.base.Preconditions.checkState;
+
 public class IrExpressionOptimizer
 {
     private final List<IrOptimizerRule> rules;
@@ -286,6 +288,12 @@ private Optional<Expression> applyRules(Expression expression, Session session,
         for (IrOptimizerRule rule : rules) {
             Optional<Expression> optimized = rule.apply(expression, session, bindings);
             if (optimized.isPresent()) {
+                checkState(
+                        expression.type().equals(optimized.get().type()),
+                        "Rule %s changed expression type from %s to %s",
+                        rule.getClass().getSimpleName(),
+                        expression.type(),
+                        optimized.get().type());
                 expression = optimized.get();
                 changed = true;
             }