Rename iceberg.add_files-procedure.enabled to `iceberg.add-files-pr…

…ocedure.enabled`
trinodb · Oct 23, 2024 · f670cd3 · f670cd3
1 parent 801f483
commit f670cd3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/docs/src/main/sphinx/connector/iceberg.md b/docs/src/main/sphinx/connector/iceberg.md
@@ -168,7 +168,7 @@ implementation is used:
 * - `iceberg.register-table-procedure.enabled`
   - Enable to allow user to call [`register_table` procedure](iceberg-register-table).
   - `false`
-* - `iceberg.add_files-procedure.enabled`
+* - `iceberg.add-files-procedure.enabled`
   - Enable to allow user to call [`add_files` procedure](iceberg-add-files).
   - `false`
 * - `iceberg.query-partition-filter-required`
@@ -590,7 +590,7 @@ nested directories, or `false` to ignore them.
 #### Add files
 
 The connector can add files from tables or locations to an existing table if
-`iceberg.add_files-procedure.enabled` is set to `true` for the catalog.
+`iceberg.add-files-procedure.enabled` is set to `true` for the catalog.
 
 Use the procedure `system.add_files_from_table` to add existing files from a
 Hive table or `system.add_files` to add existing files from a specified location

diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConfig.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConfig.java
@@ -261,7 +261,8 @@ public boolean isAddFilesProcedureEnabled()
         return addFilesProcedureEnabled;
     }
 
-    @Config("iceberg.add_files-procedure.enabled")
+    @Config("iceberg.add-files-procedure.enabled")
+    @LegacyConfig("iceberg.add_files-procedure.enabled")
     @ConfigDescription("Allow users to call the add_files procedure")
     public IcebergConfig setAddFilesProcedureEnabled(boolean addFilesProcedureEnabled)
     {

diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConfig.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConfig.java
@@ -101,7 +101,7 @@ public void testExplicitPropertyMappings()
                 .put("iceberg.materialized-views.hide-storage-table", "false")
                 .put("iceberg.materialized-views.storage-schema", "mv_storage_schema")
                 .put("iceberg.register-table-procedure.enabled", "true")
-                .put("iceberg.add_files-procedure.enabled", "true")
+                .put("iceberg.add-files-procedure.enabled", "true")
                 .put("iceberg.sorted-writing-enabled", "false")
                 .put("iceberg.query-partition-filter-required", "true")
                 .put("iceberg.query-partition-filter-required-schemas", "bronze,silver")

diff --git a/...iceberg/src/test/java/io/trino/plugin/iceberg/procedure/TestIcebergAddFilesProcedure.java b/...iceberg/src/test/java/io/trino/plugin/iceberg/procedure/TestIcebergAddFilesProcedure.java
@@ -39,7 +39,7 @@ protected QueryRunner createQueryRunner()
         dataDirectory = Files.createTempDirectory("_test_hidden");
         QueryRunner queryRunner = IcebergQueryRunner.builder()
                 .setMetastoreDirectory(dataDirectory.toFile())
-                .addIcebergProperty("iceberg.add_files-procedure.enabled", "true")
+                .addIcebergProperty("iceberg.add-files-procedure.enabled", "true")
                 .build();
 
         queryRunner.installPlugin(new TestingHivePlugin(dataDirectory));