Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CLI prompt color on dark terminal background #6190

Open
wendigo opened this issue Dec 3, 2020 · 3 comments · May be fixed by #23800
Open

Improve CLI prompt color on dark terminal background #6190

wendigo opened this issue Dec 3, 2020 · 3 comments · May be fixed by #23800
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wendigo
Copy link
Contributor

wendigo commented Dec 3, 2020

For me, on a dark themed terminal, presto prompt is invisible.

Pic:
Screenshot 2020-12-03 at 12 36 05

Screenshot 2020-12-03 at 12 36 22
@wendigo wendigo changed the title Improve CLI color scheme on dark terminal background Improve CLI prompt color on dark terminal background Dec 3, 2020
@wendigo wendigo added the good first issue Good for newcomers label Dec 3, 2020
@ebyhr ebyhr mentioned this issue Dec 3, 2020
Closed
@wendigo wendigo mentioned this issue Dec 3, 2020
Closed
@hashhar hashhar mentioned this issue Mar 4, 2021
Closed
@findepi findepi added the bug Something isn't working label Mar 4, 2021
@Ordinant
Copy link
Member

Ordinant commented May 6, 2021

Another vote for this annoyance to be fixed.

@NikashPrakash
Copy link
Member

Hey @wendigo, I am new here and would like to take this on as my first issue. If you have any pointers on where to get started I would appreciate that.

@wendigo
Copy link
Contributor Author

wendigo commented Mar 10, 2022

@NordiaG take a look at InputReader class in trino-cli module

@Ravenlol119 Ravenlol119 linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
4 participants
@wendigo @findepi @Ordinant @NikashPrakash