Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trino-cli add prompt color option #7147

Closed
wgzhao opened this issue Mar 4, 2021 · 3 comments
Closed

trino-cli add prompt color option #7147

wgzhao opened this issue Mar 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@wgzhao
Copy link
Member

wgzhao commented Mar 4, 2021

Currently the prompt of trinio-cli is dark style, which appears transparent or even unreadable in a dark-themed terminal:

image

image

two methods:

  1. Add --no--color toggle, when it enabled, the trino-cli prompt turned off highlighting
  2. Add --color <color> option, allow user specify custom prompt color.
@wgzhao wgzhao changed the title trino-cli add --no-color toggle option or similar option trino-cli add prompt color option Mar 4, 2021
@wgzhao wgzhao added the enhancement New feature or request label Mar 4, 2021
@hashhar
Copy link
Member

hashhar commented Mar 4, 2021

Can this be considered a duplicate of #6190 and #2187?

@wgzhao
Copy link
Member Author

wgzhao commented Mar 4, 2021

@hashhar Yes, I had the same problem with #6190

@hashhar
Copy link
Member

hashhar commented Mar 4, 2021

Closing as duplicate of #6190.

@hashhar hashhar closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wgzhao @hashhar