Improve error message when no common type #13829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message is important for users, so should be tested, besides error code. Many tests in `TestAnalyzer` already do that, this commit adds more assertions, but some still outstanding.
homar
approved these changes
Aug 24, 2022
|
previous CI run hit #13633 |
Improve error message when no common type for coalesce, CASE, ARRAY, IN list. Previously, the "last" common type was reported, without telling what are the input types. This also simplifies message construction in the `coerceToSingleType` helper method. Previously, the message pattern was defined by the caller, but message arguments were defined by the implementation.
findepi
force-pushed
the
findepi/coalesce-message
branch
from
03a90cf to
f0e12bb
Compare
ebyhr
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message when no common type for coalesce, CASE, ARRAY, IN
list.
Previously, the "last" common type was reported, without telling what
are the input types.
This also simplifies message construction in the
coerceToSingleTypehelper method. Previously, the message pattern was defined by the
caller, but message arguments were defined by the implementation.