-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File based column mapping for JDBC connectors #20413
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ilya Epelbaum.
|
The JDBC connector code is already hard to reason about with respect to remote vs local table and schema names. I'd rather prefer effort being spent on fixing the root cause (#17) instead of introducing additional complexity. |
I'll defer to other maintainers on their opinion about this : @trinodb/maintainers |
@trinodb/maintainers Please take a look |
I tend to agree with @hashhar that this is a complex workaround with a bunch of configuration and it avoids fixing the underlying issue. We will discuss to see if we want to support this approach. Also @IlyaEp .. if you want to fix this for yourself you could just create views in the underlying database that use the same data and change the column names to be lowercase and then you can query it all in Trino without problems. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Description
PR for issue #8745. Added the ability to specify mapping for columns in
case-insensitive-name-matching.config-file
file, like this:The main idea of the implementation: add a new field to the
JdbcColumnHandle
class that stores name of a remote column and use value of this field instead of "Trino name" in the required places.Additional context and related issues
Fixes #8745
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: