More assertion related cleanups #20522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
github-actions
bot
added
tests:hive
iceberg
findepi
force-pushed
the
findepi/assert-more
branch
from
641272b
to
23534e4
Compare
|
currently based on #20509. only new commits to be reviewed here |
findepi
force-pushed
the
findepi/assert-more
branch
from
23534e4
to
552b89d
Compare
|
just rebased after #20509 merged. no other changes yet |
findepi
force-pushed
the
findepi/assert-more
branch
from
552b89d
to
1a8b28f
Compare
wendigo
approved these changes
Jan 31, 2024
Previously the test asserted that query fails (somehow). Now it asserts that it fails with `TrinoException` and verifies the message returned to the user.
Verify that query failures are `TrinoException`. This is achieved by leveraging query assert.
Simplifies the test class.
Previously, when `nonTrinoExceptionFailure()` encountered a `TrinoException` instance, it would throw "Expecting code to raise a throwable." with little information what the problem actually is. Validating the exception explicitly (without `assertThatThrownBy`) allows producing better message in such case.
Previously `UnsupportedOperationException` could be surfaced to the user.
findepi
force-pushed
the
findepi/assert-more
branch
from
1a8b28f
to
2d2405f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20509