Add more http proxy configs for native S3 filesystem implementation #22207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
May 31, 2024
findinpath
reviewed
May 31, 2024
| @@ -106,6 +106,10 @@ public S3FileSystemFactory(OpenTelemetry openTelemetry, S3FileSystemConfig confi | |||
| config.getHttpProxy())); | |||
| httpClient.proxyConfiguration(ProxyConfiguration.builder() | |||
| .endpoint(endpoint) | |||
| .username(config.getHttpProxyUsername()) | |||
There was a problem hiding this comment.
Curiosity question: Were you able to test these changes yourself?
There was a problem hiding this comment.
nope. just trusting the sdk :) seems straightforward
To make the http proxy config options in parity with legacy implementation
anusudarsan
force-pushed
the
anu/native-fs-proxy-configs
branch
from
510b149
to
69f17a9
Compare
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
This needs review from @electrum |
mosabua
added
stale-ignore
electrum
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the http proxy config options in parity with legacy implementation
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: