-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more http proxy configs for native S3 filesystem implementation #22207
Add more http proxy configs for native S3 filesystem implementation #22207
Conversation
@@ -106,6 +106,10 @@ public S3FileSystemFactory(OpenTelemetry openTelemetry, S3FileSystemConfig confi | |||
config.getHttpProxy())); | |||
httpClient.proxyConfiguration(ProxyConfiguration.builder() | |||
.endpoint(endpoint) | |||
.username(config.getHttpProxyUsername()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curiosity question: Were you able to test these changes yourself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. just trusting the sdk :) seems straightforward
To make the http proxy config options in parity with legacy implementation
510b149
to
69f17a9
Compare
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
This needs review from @electrum |
To make the http proxy config options in parity with legacy implementation
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: