Add support for uppercase characters in partitioning table property
#22495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-partition
branch
from
fb36c4e
to
d9f7171
Compare
ebyhr
changed the title
partitioning table property
ebyhr
force-pushed
the
ebi/iceberg-partition
branch
from
d9f7171
to
3f5e3ac
Compare
anusudarsan
reviewed
Jun 25, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/PartitionFields.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-partition
branch
from
3f5e3ac
to
d9a703c
Compare
wendigo
approved these changes
Jun 26, 2024
| @@ -1300,8 +1300,20 @@ public void testPartitioningWithMixedCaseColumnUnsupportedInTrino() | |||
| sparkTableName)); | |||
| assertQueryFailure(() -> onTrino().executeQuery("ALTER TABLE " + trinoTableName + " SET PROPERTIES partitioning = ARRAY['mIxEd_COL']")) | |||
| .hasMessageContaining("Unable to parse partitioning value"); | |||
| assertQueryFailure(() -> onTrino().executeQuery("ALTER TABLE " + trinoTableName + " SET PROPERTIES partitioning = ARRAY['\"mIxEd_COL\"']")) | |||
| .hasMessageContaining("Unable to parse partitioning value"); | |||
| onTrino().executeQuery("ALTER TABLE " + trinoTableName + " SET PROPERTIES partitioning = ARRAY['\"mIxEd_COL\"']"); | |||
There was a problem hiding this comment.
nit: test case name needs changed testPartitioningWithMixedCaseColumnUnsupportedInTrino
ebyhr
force-pushed
the
ebi/iceberg-partition
branch
from
d9a703c
to
2a8e449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12668
Release notes