Add t_cdf, t_distribution scalar functions #22507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/t-dist
branch
2 times, most recently
from
b2e95ae
to
1d50f38
Compare
|
The cumulative version should follow the other cumulative distribution functions (see https://trino.io/docs/current/functions/math.html#cumulative-distribution-functions): Let me think about the probability density function form. Maybe |
martint
reviewed
Jun 26, 2024
core/trino-main/src/test/java/io/trino/operator/scalar/TestDistributionFunctions.java
Outdated
Show resolved
Hide resolved
wendigo
changed the title
|
Can you add these to the documentation? We keep the documentation in the same source tree so that we can update it when the functionality is added. |
|
@electrum done |
martint
reviewed
Jun 26, 2024
core/trino-main/src/main/java/io/trino/operator/scalar/MathFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/MathFunctions.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/t-dist
branch
2 times, most recently
from
40b6b50
to
b2490e6
Compare
losipiuk
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://support.microsoft.com/en-us/office/t-dist-function-4329459f-ae91-48c2-bba8-1ead1c6c21b2