-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for case sensitive identifiers #2350
Closed
Praveen2112
wants to merge
11
commits into
trinodb:master
from
Praveen2112:case_sensitive_identifiers_4
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b158659
Introduce NamePart for Metadata
Praveen2112 6edaa1b
!fixup Introduce NamePart for Metadata
Praveen2112 2e4b415
Introduce NameCanonicalizer for Metadata
Praveen2112 3299970
Make Session as a part of SecurityContext
Praveen2112 e601f5c
!fixup Make Session as a part of SecurityContext
Praveen2112 bdc19b2
Canonicalize names from QualifiedObjectName
Praveen2112 9a6f4f7
Remove lower case checks for SPI objects for table/view name
Praveen2112 7eb38cd
Add case senitive support for schema names
Praveen2112 534df54
Add case sensitive identifier support for Roles
Praveen2112 71e96d2
Add case sensitive support for Columns
Praveen2112 c194d5c
Add case sensitive support for Memory connector
Praveen2112 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
presto-main/src/main/java/io/prestosql/metadata/NameCanonicalizer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.prestosql.metadata; | ||
|
||
import static java.util.Locale.ENGLISH; | ||
|
||
public interface NameCanonicalizer | ||
{ | ||
NameCanonicalizer LEGACY_NAME_CANONICALIZER = (identifier, delimited) -> identifier.toLowerCase(ENGLISH); | ||
|
||
String canonicalize(String identifier, boolean delimited); | ||
|
||
default String canonicalize(NamePart namePart) | ||
{ | ||
return canonicalize(namePart.getValue(), namePart.isDelimited()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,7 @@ | |
import static java.lang.String.format; | ||
import static java.util.Collections.emptyList; | ||
import static java.util.Collections.emptyMap; | ||
import static java.util.Locale.ENGLISH; | ||
import static java.util.stream.Collectors.toList; | ||
|
||
public interface ConnectorMetadata | ||
|
@@ -806,4 +807,14 @@ default Optional<ConnectorTableHandle> applySample(ConnectorSession session, Con | |
{ | ||
return Optional.empty(); | ||
} | ||
|
||
/** | ||
* Canonicalizes the provided SQL identifier according to connector-specific rules | ||
* for the purpose of providing the name in metadata APIs | ||
*/ | ||
default String canonicalize(ConnectorSession session, String identifier, boolean delimited) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can skip passing session here. The way how remote data source is typically static and it should not change at runtime. |
||
{ | ||
// TODO: Move to model which is in accordance with SQL specification | ||
return identifier.toLowerCase(ENGLISH); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is functional? I would simply convert
getNameCanonicalizer
tocanonicalize