Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize TestNG reports uploaded to S3 as JSON #23657

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

nineinchnick
Copy link
Member

Description

To be able to process the TestNG reports uploaded to S3, when converting them to JSON, dashes in keys needs to be converted to underscores. Additionally, ensure all arrays with one item don't get converted to objects.

Tested manually.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

To be able to process the TestNG reports uploaded to S3, when converting
them to JSON, dashes in keys needs to be converted to underscores.
Additionally, ensure all arrays with one item don't get converted to
objects.
@nineinchnick
Copy link
Member Author

@wendigo PTAL

@nineinchnick
Copy link
Member Author

@wendigo ping

@losipiuk losipiuk merged commit 5739e17 into trinodb:master Oct 8, 2024
93 checks passed
@nineinchnick nineinchnick deleted the testng-report-upload branch October 8, 2024 08:09
@github-actions github-actions bot added this to the 461 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants