Add new error code and handling: QUERY_EXCEEDED_COMPILER_LIMIT #23662
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
reviewed
Oct 3, 2024
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
mduggan-starburst
force-pushed
the
duggan/method-too-large-handling
branch
from
f2f0979
to
e8af307
Compare
electrum
reviewed
Oct 3, 2024
core/trino-spi/src/main/java/io/trino/spi/StandardErrorCode.java
Outdated
Show resolved
Hide resolved
mduggan-starburst
force-pushed
the
duggan/method-too-large-handling
branch
from
e8af307
to
ab2456c
Compare
losipiuk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new error code QUERY_EXCEEDED_COMPILER_LIMIT that is used for exception MethodTooLargeException. This handles the compiler failing due to the size of the query exceeding it's limits rather than a bug or unsupported feature.
Resolves #23661
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: