Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly close input streams while decoding spooled data #23681

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Properly close input streams while decoding spooled data #23681

merged 4 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Inline variable

    @wendigo
    wendigo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9c05d29 View commit details
    Browse the repository at this point in the history

  2. Extract close logic to a separate method

    @wendigo
    wendigo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    75603e6 View commit details
    Browse the repository at this point in the history

  3. Do not materialize stream early 

    It doesn't improve performance much
    @wendigo
    wendigo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    89bdf8b View commit details
    Browse the repository at this point in the history

  4. Close the input stream while decompressing data 

    Add a test to check whether compressed streams are closed properly
    @wendigo
    wendigo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b18eb21 View commit details
    Browse the repository at this point in the history