Fix BigQuery case-insensitive mapping when cache is disabled #23698
+307
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajaks
force-pushed
the
pajaks/bigquery_cache_disabled_fix
branch
from
80e100f
to
650879f
Compare
|
/test-with-secrets sha=650879fffb6d1df4af43d237a02d36a27fa0246b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11214297178 |
nineinchnick
approved these changes
Oct 7, 2024
anusudarsan
approved these changes
Oct 7, 2024
SemionPar
approved these changes
Oct 7, 2024
ebyhr
reviewed
Oct 7, 2024
.../test/java/io/trino/plugin/bigquery/TestBigQueryCaseInsensitiveMappingWithCacheDisabled.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/bigquery/TestBigQueryCaseInsensitiveMappingWithCacheDisabled.java
Outdated
Show resolved
Hide resolved
pajaks
force-pushed
the
pajaks/bigquery_cache_disabled_fix
branch
2 times, most recently
from
e82cd2e
to
2ac20ed
Compare
When cache is disabled, all values put into cache are not persisted, causing cache-insensitive mapping failing This PR decouples mapping from cache handling
pajaks
force-pushed
the
pajaks/bigquery_cache_disabled_fix
branch
from
2ac20ed
to
8a37172
Compare
|
/test-with-secrets sha=8a37172f0d0172c73c30650988d4fb2135dcb54b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11231655980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cache is disabled, all values put into cache are not persisted, causing cache-insensitive mapping failing
This PR decouples mapping from cache handling
Release notes