Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of FINISHING queries #23702

Conversation

losipiuk
Copy link
Member

@losipiuk losipiuk commented Oct 7, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
@losipiuk losipiuk requested a review from wendigo October 7, 2024 11:32
@losipiuk losipiuk added the no-release-notes This pull request does not require release notes entry label Oct 7, 2024
@wendigo
Copy link
Contributor

wendigo commented Oct 7, 2024

Context?

Sometimes a query may spend a sifnificant amount of time in FINISHING
state if query result is large and all tasks already finished execution.
This is possible with fault tolerant execution.
@losipiuk losipiuk force-pushed the lukaszos/expose-number-of-finishing-queries-4197bc branch from d8237f3 to 327de48 Compare October 7, 2024 13:49
@losipiuk
Copy link
Member Author

losipiuk commented Oct 7, 2024

Updated the commit message.
Alternative would be to coung FINISHING queries as RUNNING. Probably ok too - but a bit less information.

@losipiuk losipiuk merged commit a803861 into trinodb:master Oct 7, 2024
14 of 67 checks passed
@github-actions github-actions bot added this to the 461 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants