Document accessing multiple azure storage accounts in single catalog #23716
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Oct 8, 2024
|
Also .. just to be sure .. this page is generic for all table formats.. so the assumption is that the approach works for all of them. If not we need to clarify |
anusudarsan
force-pushed
the
anu/doc-azure-native-fs-multiple-accounts
branch
from
5f05da9
to
1f05450
Compare
anusudarsan
commented
Oct 8, 2024
There was a problem hiding this comment.
@mosabua addressed comments. Also added a bit more details. please re-review
mosabua
requested changes
Oct 8, 2024
anusudarsan
force-pushed
the
anu/doc-azure-native-fs-multiple-accounts
branch
from
1f05450
to
9ffb641
Compare
mosabua
reviewed
Oct 8, 2024
mosabua
reviewed
Oct 8, 2024
There was a problem hiding this comment.
One nit and a final update of the commit message please .. its too long .. use a shorter title and if needed a paragraph after, then the PR is good to go
https://trino.io/development/process#pull-request-and-commit-guidelines-
anusudarsan
force-pushed
the
anu/doc-azure-native-fs-multiple-accounts
branch
from
9ffb641
to
ba52a0a
Compare
mosabua
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #23538
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: