Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check permission when registering tables in Iceberg and Delta Lake #23728

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Check permission when registering tables in Iceberg and Delta Lake #23728

merged 1 commit into from
Oct 9, 2024
+45 −2

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 9, 2024 •
edited
Loading

Description

This procedure is very similar to CREATE TABLE. We should call AccessControl#checkCanCreateTable in the procedure.

Release notes

## Iceberg, Delta Lake
* Enforce access control for new tables in the `register_table` procedure. ({issue}`23728`)

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
@github-actions github-actions bot added iceberg Iceberg connector delta-lake Delta Lake connector labels Oct 9, 2024
@ebyhr ebyhr merged commit 0a3a89f into trinodb:master Oct 9, 2024
45 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-delta-register-table-access-control branch October 9, 2024 10:22
@github-actions github-actions bot added this to the 461 milestone Oct 9, 2024
@mosabua mosabua mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@krvikash krvikash Awaiting requested review from krvikash

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector iceberg Iceberg connector
Milestone
461
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @raunaqmorarka