Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about removed *.http-client.max-connections properties #23762

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Oct 11, 2024

Description

The linked airlift PR removed the http-client.max-connections property. This was reflected in the Trino documentation with #20101 but should have been given a breaking change since the property was applied by some users.

Additional context and related issues

#20966
#20797

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the commit message as well please

How about

"Add note about removed *.http-client.max-connections"

docs/src/main/sphinx/release/release-440.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-440.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Oct 18, 2024

Ping @jhlodin

@jhlodin jhlodin force-pushed the jl/missing-http-client-rn branch 2 times, most recently from 5f0abc4 to 75b7daa Compare October 24, 2024 17:11
@jhlodin jhlodin changed the title Add missing breaking change for http client property removal Add note about removed *.http-client.max-connections properties Oct 24, 2024
@jhlodin jhlodin requested a review from mosabua October 24, 2024 17:12
@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 24, 2024

Addressed comments @mosabua

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you.

@mosabua mosabua merged commit f986824 into trinodb:master Oct 24, 2024
5 checks passed
@github-actions github-actions bot added this to the 464 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants