Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant check #23776

Merged
merged 1 commit into from
Oct 16, 2024
+1 −3
Merged

Remove redundant check #23776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/trino-main/src/main/java/io/trino/sql/planner/plan/AggregationNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import io.trino.sql.planner.Symbol;
import io.trino.type.FunctionType;

import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -233,8 +232,7 @@ public boolean producesDistinctRows()
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is probably wrong, e.g: when there are multiple grouping sets.
Also, this check is too probably too strict, e.g: with regards to hash symbols. cc @Praveen2112

return aggregations.isEmpty() &&
!groupingSets.getGroupingKeys().isEmpty() &&
outputs.size() == groupingSets.getGroupingKeys().size() &&
new HashSet<>(outputs).containsAll(groupingSets.getGroupingKeys());
outputs.size() == groupingSets.getGroupingKeys().size();
}

public boolean isDecomposable(Session session, Metadata metadata)
Expand Down