Fix incorrect simplification of CASE with constant boolean results #23796
+163
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expressions such as:
were being incorrectly optimized. The terms in the rewritten boolean expression need to reflect the fact that all the preceding conditions should've evaluated to false in order for a given condition to evaluate to true. The optimization was ignoring them, which could result in incorrect results when the conditions are not exclusive.
For example:
Previously, it was being rewritten as:
However, if
a
is true, then the first branch of the CASE should be evaluated and the expression should return false.Fixes #23787
Release notes
(x) Release notes are required, with the following suggested text: