Add hive.metastore.glue.skip-archive config option
#23817
+202
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-with-secrets sha=5d538527d13412ac48610f78f48d692a49480102 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11384047749 |
nineinchnick
force-pushed
the
hive-glue-skip-archive
branch
from
5d53852
to
831245a
Compare
findinpath
reviewed
Oct 18, 2024
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastoreConfig.java
Outdated
Show resolved
Hide resolved
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/IcebergGlueCatalogModule.java
Outdated
Show resolved
Hide resolved
...ino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/IcebergGlueCatalogModule.java
Outdated
Show resolved
Hide resolved
...rg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogSkipArchive.java
Outdated
Show resolved
Hide resolved
anusudarsan
approved these changes
Oct 18, 2024
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreModule.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreModule.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
hive-glue-skip-archive
branch
from
831245a
to
e8f81a1
Compare
wendigo
approved these changes
Oct 23, 2024
ebyhr
reviewed
Oct 23, 2024
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveExecutionInterceptor.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ebyhr
reviewed
Oct 23, 2024
...trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/v1/GlueHiveMetastoreConfig.java
Outdated
Show resolved
Hide resolved
...hive/src/test/java/io/trino/plugin/hive/metastore/glue/TestGlueHiveMetastoreSkipArchive.java
Outdated
Show resolved
Hide resolved
...hive/src/test/java/io/trino/plugin/hive/metastore/glue/TestGlueHiveMetastoreSkipArchive.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
hive-glue-skip-archive
branch
from
e8f81a1
to
f7a47e3
Compare
When set to true, updating tables in Glue does not create an archived version of the table. Glue tables are updated during INSERT operations, so this option can be used to avoid reaching the limit of table versions, when executing a large number of such operations.
nineinchnick
force-pushed
the
hive-glue-skip-archive
branch
from
f7a47e3
to
3c3d1dd
Compare
|
/test-with-secrets sha=3c3d1dd43e6e3cbd87550ce038b5a288b627ac6f |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11515725284 |
|
All green! |
findinpath
reviewed
Oct 25, 2024
| return skipArchive; | ||
| } | ||
|
|
||
| @Config("iceberg.glue.skip-archive") |
There was a problem hiding this comment.
Remove also from the metastores.md if the decision is to remove the property.
Are we talking about a "breaking change" if we remove the property?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When set to true, updating tables in Glue does not create an archived
version of the table. Glue tables are updated during INSERT operations,
so this option can be used to avoid reaching the limit of table
versions, when executing many such operations.
In the second commit, I also added it to the legacy v1 Glue Metastore. I don't think it's needed there, it might help when migrating Iceberg from v1 Glue to the latest one, at least to avoid binding issues in Guice modules.
Additional context and related issues
This is modeled after #14336
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: