Fix change data feed with delete vectors #23827
Merged
+124
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
force-pushed
the
homar/fix_change_data_feed_with_delete_vecotrs
branch
from
c1c552f
to
387f1e5
Compare
homar
changed the title
|
/test-with-secrets sha=387f1e530a37fb6c0e7e6b2f818f68ee0784599a |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11412968446 |
|
@ebyhr ci passed, so what do you think ? |
ebyhr
force-pushed
the
homar/fix_change_data_feed_with_delete_vecotrs
branch
from
387f1e5
to
6de90ba
Compare
ebyhr
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23620
Additional context and related issues
When deletion vectors were enabled code that is supposed to create
update_preimagewas not executed.Release notes