-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dereference pushdown in Elasticsearch #23839
base: master
Are you sure you want to change the base?
Add support for dereference pushdown in Elasticsearch #23839
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@mayankvadariya Can you please help with an initial review ? |
This comment was marked as outdated.
This comment was marked as outdated.
dd51580
to
1be6202
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Hi @striderarun Could you please fix the |
This comment was marked as outdated.
This comment was marked as outdated.
7e37b07
to
1be6202
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@krvikash @mayankvadariya The CI failure is due to Checkstyle violation "Error: src/test/java/io/trino/plugin/elasticsearch/ElasticsearchServer.java:[54] (regexp) RegexpSinglelineJava: No new line before extends/implements". But as you can see in ElasticsearchServer.java file https://github.com/trinodb/trino/pull/23839/files#diff-b59c7df884fdb8b4e27c9ecdb91f8e9de59feda646bc1cad16d300d7a231d5a9, I am also using the Airlift codestyle in my IntelliJ IDE as documented here: https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#code-style I am not sure if I am overlooking something since this is my first pull request in Trino. Do you see anything obvious that I am missing here that explains the Checkstyle violation? |
plugin/trino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
1be6202
to
c17ec04
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@mayankvadariya Would greatly appreciate your help in reviewing this PR when you get a chance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed, Overall LGTM. Still need to review the test classes.
plugin/trino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchConfig.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...n/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
...lasticsearch/src/test/java/io/trino/plugin/elasticsearch/BaseElasticsearchConnectorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/trino/plugin/elasticsearch/TestElasticsearchComplexTypePredicatePushDown.java
Show resolved
Hide resolved
c17ec04
to
42fd5aa
Compare
42fd5aa
to
033816b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try using client from OpenSearchServer to see if it helps test pass.
...ch/src/test/java/io/trino/plugin/elasticsearch/TestElasticsearchProjectionPushdownPlans.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/trino/plugin/elasticsearch/TestElasticsearchComplexTypePredicatePushDown.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/trino/plugin/elasticsearch/TestElasticsearchComplexTypePredicatePushDown.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/trino/plugin/elasticsearch/TestElasticsearchComplexTypePredicatePushDown.java
Outdated
Show resolved
Hide resolved
...ch/src/test/java/io/trino/plugin/elasticsearch/TestElasticsearchProjectionPushdownPlans.java
Outdated
Show resolved
Hide resolved
...lasticsearch/src/test/java/io/trino/plugin/elasticsearch/BaseElasticsearchConnectorTest.java
Outdated
Show resolved
Hide resolved
033816b
to
38a27d3
Compare
Thanks for your comment, @mayankvadariya. The tests passed with your suggestion. |
Description
Add dereference pushdown support in ElasticSearch. (Issue: #23069)
Learn more about dereference pushdown at
https://trino.io/docs/current/optimizer/pushdown.html#dereference-pushdown
https://trino.io/blog/2020/08/14/dereference-pushdown.html
Additional context and related issues
The feature is enabled by default. Can be disabled by setting elasticsearch.projection-pushdown-enabled configuration property or elasticsearch.projection_pushdown_enabled session property to false.
Based on reference implementation for OpenSearch dereference pushdown in #22646
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text: