Disallow window framing clause for certain window functions #23856
+156
−118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #23742 describes unexpected behavior of the
lag
function when used with a window framing clause. It turns out that the problem does not exist in the current version of Trino. This PR adds a test to confirm this. Additionally, it adds a check to verify that the window framing clause is not used with thentile
,rank
,dense_rank
,percent_rank
,cume_dist
, androw_number
functions, which aligns with the SQL specification.Additional context and related issues
Fixes #23742
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: