Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce logging noise #23872

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Reduce logging noise #23872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff090e
Reduce logging in product tests
wendigo Oct 23, 2024
4140b4d
Use new CONTAINER_TRINO_LOGGING_CONFIG constant
wendigo Oct 23, 2024
4ed7302
Reduce noisy logging in the docker deployment
wendigo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...uct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public final class Standard
public static final String CONTAINER_CONF_ROOT = "/docker/trino-product-tests/";
public static final String CONTAINER_TRINO_ETC = CONTAINER_CONF_ROOT + "conf/trino/etc";
public static final String CONTAINER_TRINO_JVM_CONFIG = CONTAINER_TRINO_ETC + "/jvm.config";
public static final String CONTAINER_TRINO_LOGGING_CONFIG = CONTAINER_TRINO_ETC + "/log.properties";
public static final String CONTAINER_TRINO_SECRETS_CONFIG = CONTAINER_TRINO_ETC + "/secrets.toml";
public static final String CONTAINER_TRINO_ACCESS_CONTROL_PROPERTIES = CONTAINER_TRINO_ETC + "/access-control.properties";
public static final String CONTAINER_TRINO_CONFIG_PROPERTIES = CONTAINER_TRINO_ETC + "/config.properties";
Expand Down Expand Up @@ -195,6 +196,7 @@ public static DockerContainer createTrinoContainer(DockerFiles dockerFiles, File
.withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath()), "/docker/trino-product-tests")
.withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("conf/trino/etc/jvm.config")), CONTAINER_TRINO_JVM_CONFIG)
.withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("conf/trino/etc/secrets.toml")), CONTAINER_TRINO_SECRETS_CONFIG)
.withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("conf/trino/etc/log.properties")), CONTAINER_TRINO_LOGGING_CONFIG)
.withCopyFileToContainer(forHostPath(dockerFiles.getDockerFilesHostPath("health-checks/trino-health-check.sh")), CONTAINER_HEALTH_D + "trino-health-check.sh")
// the server package is hundreds MB and file system bind is much more efficient
.withFileSystemBind(serverPackage.getPath(), "/docker/trino-server.tar.gz", READ_ONLY)
Expand Down
4 changes: 4 additions & 0 deletions ...ests-launcher/src/main/resources/docker/trino-product-tests/conf/trino/etc/log.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Reduce levels of some known noisy loggers
org.eclipse.jetty=ERROR
org.glassfish.jersey.server.ServerRuntime$Responder=OFF
io.airlift.concurrent.BoundedExecutor=OFF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it produce, that we want to disable it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's shut down it rejects all of the tasks that log a bunch of errors.