Introduce CassandraSessionConfigurator #23899
Open
+435
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This abstraction allows us to isolate each feature as an independent module.
Praveen2112
requested review from
ebyhr,
krvikash,
findinpath,
vlad-lyutenko and
marcinsbd
Praveen2112
force-pushed
the
praveen/cassandra_cleanup
branch
from
f85511f
to
3d2b875
Compare
Praveen2112
force-pushed
the
praveen/cassandra_cleanup
branch
from
3d2b875
to
30e0ef9
Compare
ebyhr
approved these changes
Oct 24, 2024
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/ssl/TestCassandraSslConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/ssl/TestCassandraSslConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/ssl/CassandraSslConfig.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/cassandra_cleanup
branch
from
30e0ef9
to
4d9628a
Compare
|
@ebyhr Thanks a lot for the review. AC |
ebyhr
reviewed
Oct 25, 2024
plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/tls/CassandraSslConfig.java
Outdated
Show resolved
Hide resolved
Additionally we have introduced a new property `cassandra.security` which needs to be set to `PASSWORD` for enabling password authentication.
Praveen2112
force-pushed
the
praveen/cassandra_cleanup
branch
from
4d9628a
to
8610bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CassandraSessionConfiguratorallows us to isolate various parts of the code related to configuring the Cassandra client and allowing us to have a dedicated config object.module for each component like SSL related configuration. Apart from this we have also introduced a another configuration propertycassandra.securitywhich should be set toPASSWORDif we are using password based authentication for cassandra.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: