Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output types back to EXPLAIN output #382

Conversation

kokosing
Copy link
Member

@kokosing kokosing commented Mar 5, 2019

Add output types back to EXPLAIN output

Output types were removed unintentionally in
1630408

Extracted from: prestodb/presto#12393

@cla-bot
Copy link

cla-bot bot commented Mar 5, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

@@ -137,4 +137,26 @@ public String getDetails()
{
return estimatedCost;
}

public static class OutputSymbol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypedSymbol, SymbolAndType? "Output" is a property of how it's used, but the concept this represents is a symbol + its type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed as separate commit, I do not feel comfortable editing (commit) code that is authored by some else. Should I squash it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please squash it. That is ok, it’s similar to applying comments for someone else’s change before merging a PR.

@cla-bot
Copy link

cla-bot bot commented Mar 7, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

Output types were removed unintentionally in
1630408

Extracted from: prestodb/presto#12393
@kokosing kokosing force-pushed the origin/master/101_port_12393_from_legacy_presto branch from 4b48864 to 67c2e63 Compare March 7, 2019 19:45
@cla-bot
Copy link

cla-bot bot commented Mar 7, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

@kokosing kokosing merged commit 00c8795 into trinodb:master Mar 8, 2019
@kokosing kokosing deleted the origin/master/101_port_12393_from_legacy_presto branch March 8, 2019 10:00
@kokosing kokosing added this to the 306 milestone Mar 8, 2019
@kokosing kokosing mentioned this pull request Mar 8, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants