Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time spent in WAITING_FOR_RESOURCES state to query timeline log #461

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

raunaqmorarka
Copy link
Member

Adding resource wait time of a query to query timeline log as it can be useful to have this information from logs for debugging

@cla-bot
Copy link

cla-bot bot commented Mar 12, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Raunaq Morarka.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@martint
Copy link
Member

martint commented Mar 13, 2019

Thanks for submitting this. We should also consider adding it to the QueryCompletedEvent so that event listener plugins can access it.

@raunaqmorarka
Copy link
Member Author

Thanks for submitting this. We should also consider adding it to the QueryCompletedEvent so that event listener plugins can access it.

@martint I've added resource waiting time to QueryStatistics to make it accessible in QueryCompletedEvent

Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge it once Travis passes.

@raunaqmorarka
Copy link
Member Author

raunaqmorarka commented Mar 13, 2019

Thanks! I'll merge it once Travis passes.

@martint Travis job seems to be stuck in queued state, is it possible to re-submit it ?

@martint martint merged commit 9235cee into trinodb:master Mar 14, 2019
@martint martint mentioned this pull request Mar 14, 2019
6 tasks
@raunaqmorarka raunaqmorarka deleted the log_waiting_time branch March 17, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants