Export @trinsic/trinsic/browser properly
#906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fundthmcalculus
requested review from
tmarkovski and
MichaelEdwardBlack
as code owners
tmarkovski
reviewed
Aug 1, 2022
|
I tried that. That was what required the lib browser import directive. Apparently you can't have a default import from a lib folder from what I can tell. |
|
This looks promising: nodejs/node#14970 (comment) |
|
Appears to work locally, testing with one final rc before sending https://github.com/trinsic-id/sdk/issues/881 |
|
It works as expected. |
fundthmcalculus
changed the title
@trinsic/trinsic/browser properly
geel9
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.