-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Have ability to split the build in CI #7076
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an API comment, since API's are sticky you try to get them right the first time because the overhead of changing them later is high.
parser.add_argument( | ||
"--cache-from-map", | ||
action="append", | ||
required=False, | ||
help="A set of docker images to `--cache-from` where applicable to help speedup builds", | ||
default=[ | ||
"tritonserver_buildbase", | ||
"tritonserver_buildbase_cache0", | ||
"tritonserver_buildbase_cache1", | ||
], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that it was called a map
before, but it's really just a list. What do you think about changing this to something like --cache-image
or --cache-images
? We can make use of the multiple arguments in a couple of different ways. We can use the action="append"
or the nargs='+'
fields (SO comment for example). I might lean towards the --cache-image
with action="append"
API just because we have precedent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think name was used to keep consistency with original command which is relates to: docker build --cache-from
$ docker build --help | grep cache-from
--cache-from stringArray External cache sources (e.g., "user/app:cache", "type=local,src=path/to/dir")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about --cache-from-list
?
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
MOTIVATION:
Triton Server CI is monolithic, I would like to add ability splitting the CI and build it per backend if needed
CHANGES:
--ci-split
and--cache-from-map
--ci-split
VERIFICATION: