remove DecomposeConversions pass

triton-lang · Apr 8, 2024 · 8ca5404 · 8ca5404
1 parent fedf8b5
commit 8ca5404
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 97 deletions.
diff --git a/bin/RegisterTritonDialects.h b/bin/RegisterTritonDialects.h
@@ -64,7 +64,6 @@ inline void registerTritonDialects(mlir::DialectRegistry &registry) {
   // mlir::registerTritonAMDGPUPasses();
 
   mlir::registerTritonAMDGPUAccelerateMatmul();
-  mlir::registerTritonAMDGPUDecomposeConversions();
   mlir::registerTritonAMDGPUOptimizeEpilogue();
   mlir::registerTritonAMDGPURemoveLayoutConversions();
   mlir::registerTritonAMDGPUReorderInstructions();

diff --git a/third_party/amd/include/TritonAMDGPUTransforms/Passes.h b/third_party/amd/include/TritonAMDGPUTransforms/Passes.h
@@ -24,8 +24,6 @@ std::unique_ptr<Pass> createTritonAMDGPUCoalescePass();
 
 std::unique_ptr<Pass> createTritonAMDGPUReorderInstructionsPass();
 
-std::unique_ptr<Pass> createTritonAMDGPUDecomposeConversionsPass();
-
 std::unique_ptr<Pass> createTritonAMDGPURemoveLayoutConversionsPass();
 
 std::unique_ptr<Pass> createTritonAMDGPUVerifier();

diff --git a/third_party/amd/include/TritonAMDGPUTransforms/Passes.td b/third_party/amd/include/TritonAMDGPUTransforms/Passes.td
@@ -141,14 +141,4 @@ def TritonAMDGPUReorderInstructions: Pass<"tritonamdgpu-reorder-instructions", "
   let dependentDialects = [];
 }
 
-def TritonAMDGPUDecomposeConversions: Pass<"tritonamdgpu-decompose-conversions", "mlir::ModuleOp"> {
-  let summary = "Decompose convert[distributed -> dotOperand] into convert[distributed -> shared -> dotOperand]";
-
-  let description = "Decomposing conversions this way makes it possible to use CSE and re-use #shared tensors";
-
-  let constructor = "mlir::createTritonAMDGPUDecomposeConversionsPass()";
-
-  let dependentDialects = [];
-}
-
 #endif
diff --git a/third_party/amd/lib/TritonAMDGPUTransforms/CMakeLists.txt b/third_party/amd/lib/TritonAMDGPUTransforms/CMakeLists.txt
@@ -1,6 +1,5 @@
 add_triton_library(TritonAMDGPUTransforms
   AccelerateAMDMatmul.cpp
-  DecomposeConversions.cpp
   OptimizeEpilogue.cpp
   RemoveLayoutConversions.cpp
   ReorderInstructions.cpp

diff --git a/third_party/amd/lib/TritonAMDGPUTransforms/DecomposeConversions.cpp b/third_party/amd/lib/TritonAMDGPUTransforms/DecomposeConversions.cpp
diff --git a/third_party/amd/python/triton_amd.cc b/third_party/amd/python/triton_amd.cc
@@ -25,8 +25,6 @@ void init_triton_amd_passes_ttgpuir(py::module &&m) {
   ADD_PASS_WRAPPER_2("add_accelerate_matmul",
                      mlir::createTritonAMDGPUAccelerateMatmulPass,
                      const std::string, int);
-  ADD_PASS_WRAPPER_0("add_decompose_conversions",
-                     mlir::createTritonAMDGPUDecomposeConversionsPass);
   ADD_PASS_WRAPPER_0("add_optimize_epilogue",
                      mlir::createTritonAMDGPUOptimizeEpiloguePass);
   ADD_PASS_WRAPPER_0("add_remove_layout_conversions",