[DOCUMENTATION] Added documentation to the code that lowers reduce to llvm #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptillet
reviewed
Apr 12, 2023
| auto srcOrd = triton::gpu::getOrder(srcLayout); | ||
| // The elements owned by each thread, e.g. [2, 2] means that each thread |
There was a problem hiding this comment.
This is not true. getSizePerThread is just the contiguous size. Also this comment isn't very useful as it almost just repeats the function call name. Maybe getSizePerThread should be renamed getContiguousSizePerThread and comments be there?
There was a problem hiding this comment.
I think it's clear, it wasn't confusing to me.
ptillet
reviewed
Apr 12, 2023
| auto sizePerThread = triton::gpu::getSizePerThread(srcLayout); | ||
| auto srcShape = srcTy.getShape(); | ||
|
|
||
| auto llvmElemTy = getTypeConverter()->convertType(srcTy.getElementType()); | ||
| auto llvmIndexTy = getTypeConverter()->getIndexType(); | ||
| auto elemPtrTy = LLVM::LLVMPointerType::get(llvmElemTy, 3); | ||
| auto indexPtrTy = LLVM::LLVMPointerType::get(llvmIndexTy, 3); | ||
| // The shared memory base address |
There was a problem hiding this comment.
I don't think this comment is very useful, it just repeats the name of the function below
ptillet
approved these changes
Apr 12, 2023
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
ZzEeKkAa
pushed a commit
to ZzEeKkAa/triton
that referenced
this pull request
Aug 5, 2024
… in tt.dot operation lowering. (triton-lang#1514) Support the repCluster field in tt.dot operation lowering. --------- Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com> Co-authored-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.