relock gil #3196
Merged
relock gil #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptillet
reviewed
Feb 25, 2024
python/src/llvm.cc
Outdated
| @@ -239,6 +239,7 @@ void init_triton_llvm(py::module &&m) { | |||
| } | |||
| std::string obj = translateLLVMIRToASM( | |||
| *module, triple, proc, features, flags, enable_fp_fusion, isObject); | |||
| py::gil_scoped_acquire no_threads; | |||
There was a problem hiding this comment.
LGTM, but can you fix the formatting? :)
peterbell10
reviewed
Feb 27, 2024
python/src/llvm.cc
Outdated
| @@ -239,6 +239,7 @@ void init_triton_llvm(py::module &&m) { | |||
| } | |||
| std::string obj = translateLLVMIRToASM( | |||
| *module, triple, proc, features, flags, enable_fp_fusion, isObject); | |||
| py::gil_scoped_acquire no_threads; | |||
There was a problem hiding this comment.
Minor issue: this results in an unnecessary sequence of unlock -> lock -> unlock -> lock because gil_scoped_acquire releases the GIL in its destructor. It would be better to move the gil_scoped_release into a more narrow scope, e.g.
{
py::gil_scoped_release allow_threads;
...
}
return isObject ? py::bytes(obj) : py::str(obj);Releasing causes a fault in the 'if (isObject) ' path because a malloc happens and the gil is assumed to be held. Signed-off-by: Tom Rix <trix@redhat.com>
trixirt
force-pushed
the
gil_scoped_acquire
branch
from
6f99015 to
c34cf2e
Compare
|
Changes requested have been made. |
ptillet
approved these changes
Mar 9, 2024
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
Releasing causes a fault in the 'if (isObject) ' path because a malloc happens and the gil is assumed to be held. Signed-off-by: Tom Rix <trix@redhat.com> Co-authored-by: Philippe Tillet <phil@openai.com>
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
Releasing causes a fault in the 'if (isObject) ' path because a malloc happens and the gil is assumed to be held. Signed-off-by: Tom Rix <trix@redhat.com> Co-authored-by: Philippe Tillet <phil@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing causes a fault in the 'if (isObject) ' path because a malloc happens and the gil is assumed to be held.