[AMD][Navi31] Convert WMMA dot op to LLVM #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ThomasRaoux
reviewed
Feb 26, 2024
| * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE | ||
| * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
| #ifdef USE_ROCM |
|
|
||
| } // namespace | ||
|
|
||
| LogicalResult convertWMMA(triton::DotOp op, triton::DotOp::Adaptor adaptor, |
There was a problem hiding this comment.
can you add a basic lit tests to make sure this codes runs.
There was a problem hiding this comment.
Yep. working on it
joviliast
force-pushed
the
wmma-convert-dot
branch
3 times, most recently
from
b3843b3 to
66e7ea7
Compare
|
#3254 - this pr is also required for testing |
joviliast
force-pushed
the
wmma-convert-dot
branch
from
66e7ea7 to
8d1c067
Compare
|
Added lit test. Please check. |
joviliast
force-pushed
the
wmma-convert-dot
branch
from
b99208b to
56daf50
Compare
-Add WMMA conversion logic for dot operation -Fix helper hunctions for WMMA layout -Add lit test for WMMA dot operation conversion Signed-off-by: joviliast <iveselov.nn@gmail.com>
joviliast
force-pushed
the
wmma-convert-dot
branch
from
56daf50 to
10e1560
Compare
ThomasRaoux
added a commit
to ThomasRaoux/triton
that referenced
this pull request
Mar 5, 2024
This reverts commit 9cfad37.
|
sorry reverting this as it seems to cause a build failure due to a previous PR. Could you resubmit it? |
ThomasRaoux
added a commit
that referenced
this pull request
Mar 5, 2024
#3292 done |
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
-Add WMMA conversion logic for dot operation -Fix helper hunctions for WMMA layout -Add lit test for WMMA dot operation conversion Signed-off-by: joviliast <iveselov.nn@gmail.com>
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
…triton-lang#3284) This reverts commit 52b3549. There has been an inflight collision with some refactoring causing a build break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add WMMA conversion logic for dot operation
-Fix helper hunctions for WMMA layout
-Add lit test for WMMA dot operation conversion