Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level permissions to the workflows #3262

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

pbchekin
Copy link
Contributor

@pbchekin pbchekin commented Mar 1, 2024

OpenSSF Scorecard Report shows zero score for "Token-Permissions", which can be easily fixed by adding a top level permissions to the existing workflows.

This report can be also generated locally with

$ docker run --rm gcr.io/openssf/scorecard:stable  \
  --show-details --checks Token-Permissions --repo=openai/triton --format json | jq -r '.checks[].details[]' | grep -e '^Warn:'
Warn: no topLevel permission defined: .github/workflows/compare-artifacts.yml:1
Warn: no topLevel permission defined: .github/workflows/documentation.yml:1
Warn: no topLevel permission defined: .github/workflows/integration-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/test-backends.yml:1
Warn: no topLevel permission defined: .github/workflows/torch-inductor-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/wheels.yml:1

@pbchekin pbchekin requested a review from ptillet as a code owner March 1, 2024 22:18
Copy link
Collaborator

@jlebar jlebar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ptillet ptillet merged commit 1ed91a1 into triton-lang:main Mar 9, 2024
4 checks passed
htyu pushed a commit to htyu/triton that referenced this pull request Mar 20, 2024
[OpenSSF Scorecard
Report](https://securityscorecards.dev/viewer/?uri=github.com/openai/triton)
shows zero score for "Token-Permissions", which can be easily fixed by
adding a top level permissions to the existing workflows.

This report can be also generated locally with

```
$ docker run --rm gcr.io/openssf/scorecard:stable  \
  --show-details --checks Token-Permissions --repo=openai/triton --format json | jq -r '.checks[].details[]' | grep -e '^Warn:'
Warn: no topLevel permission defined: .github/workflows/compare-artifacts.yml:1
Warn: no topLevel permission defined: .github/workflows/documentation.yml:1
Warn: no topLevel permission defined: .github/workflows/integration-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/test-backends.yml:1
Warn: no topLevel permission defined: .github/workflows/torch-inductor-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/wheels.yml:1
```
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
[OpenSSF Scorecard
Report](https://securityscorecards.dev/viewer/?uri=github.com/openai/triton)
shows zero score for "Token-Permissions", which can be easily fixed by
adding a top level permissions to the existing workflows.

This report can be also generated locally with

```
$ docker run --rm gcr.io/openssf/scorecard:stable  \
  --show-details --checks Token-Permissions --repo=openai/triton --format json | jq -r '.checks[].details[]' | grep -e '^Warn:'
Warn: no topLevel permission defined: .github/workflows/compare-artifacts.yml:1
Warn: no topLevel permission defined: .github/workflows/documentation.yml:1
Warn: no topLevel permission defined: .github/workflows/integration-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/test-backends.yml:1
Warn: no topLevel permission defined: .github/workflows/torch-inductor-tests.yml:1
Warn: no topLevel permission defined: .github/workflows/wheels.yml:1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants