Recommit [OPTIMIZATION] Fix addptr combine pattern (#3148) #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomasRaoux, this will fix the crash. |
junparser
force-pushed
the
addptr-combine
branch
from
e1fae3b to
bba2930
Compare
ThomasRaoux
approved these changes
Mar 6, 2024
|
Seems the error log "RuntimeError: CUDA error: CUBLAS_STATUS_ALLOC_FAILED when calling `cublasCreate(handle)" is irrelevant with this patch |
GPU errors are asynchronous so in general this poont to a crash that may be due to code generated by triton. I'll kick off a rerun but it is most likely a legetimate error |
junparser
force-pushed
the
addptr-combine
branch
2 times, most recently
from
f6e3d34 to
c739377
Compare
|
@ThomasRaoux would you help merge this? Thanks! |
Add addptr(addptr(%ptr, %idx0), %idx1) pattern again with constraint which makes sure that both element type of offset should be same.
junparser
force-pushed
the
addptr-combine
branch
from
c739377 to
bd98f82
Compare
ThomasRaoux
approved these changes
Mar 11, 2024
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…triton-lang#3289) Add addptr(addptr(%ptr, %idx0), %idx1) pattern again with constraint which makes sure that both element type of offset should be same.
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…triton-lang#3289) Add addptr(addptr(%ptr, %idx0), %idx1) pattern again with constraint which makes sure that both element type of offset should be same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add addptr(addptr(%ptr, %idx0), %idx1) pattern again with constraint which makes sure that both element type of offset should be same.