[TEST] Use LABEL scopes in lit tests #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's quite easy to unexpectedly use a match from a different CHECK-LABEL in a lit test, which is likely not what the author intended. Prevent this from happening by invoking FileCheck with variable scopes enabled (and fix the failures detected this way). This also makes the file check use in Triton consistent with upstream MLIR.
|
Note: the actual issue that I detected with this was the use of |
Jokeren
approved these changes
Mar 6, 2024
|
This is a good change, thanks Goran. |
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
It's quite easy to unexpectedly use a match from a different CHECK-LABEL in a lit test, which is likely not what the author intended. Prevent this from happening by invoking FileCheck with variable scopes enabled (and fix the failures detected this way). This also makes the file check use in Triton consistent with upstream MLIR.
binarman
pushed a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
It's quite easy to unexpectedly use a match from a different CHECK-LABEL in a lit test, which is likely not what the author intended. Prevent this from happening by invoking FileCheck with variable scopes enabled (and fix the failures detected this way). This also makes the file check use in Triton consistent with upstream MLIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite easy to unexpectedly use a match from a different CHECK-LABEL in a lit test, which is likely not what the author intended.
Prevent this from happening by invoking FileCheck with variable scopes enabled (and fix the failures detected this way). This also makes the file check use in Triton consistent with upstream MLIR.