Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKEND] Transformed TritonGPUToLLVMPass to TritonGPUToLLVM in amd backend #3328

Merged
merged 21 commits into from
Mar 11, 2024
Merged

[BACKEND] Transformed TritonGPUToLLVMPass to TritonGPUToLLVM in amd backend #3328

merged 21 commits into from
Mar 11, 2024

Conversation

zahimoud
Copy link
Contributor

@zahimoud zahimoud commented Mar 8, 2024 •
edited
Loading

Changes:

  • Extracted SPMD, Print, ControlFlow patterns to separate files
  • Deleted TritonGPUToLLVM
  • Renamed TritonGPUToLLVMPass to TritonGPUToLLVM
  • Extracted ControlFlow, and GetProgramId, FuncOp patterns to common lib

@zahimoud zahimoud requested a review from ThomasRaoux March 8, 2024 22:24
@zahimoud zahimoud marked this pull request as ready for review March 8, 2024 22:38
@zahimoud
Copy link
Contributor Author

zahimoud commented Mar 8, 2024 •
edited
Loading

Running amd backend tests link

ThomasRaoux
ThomasRaoux approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

include/triton/Conversion/TritonGPUToLLVM/TargetInfoBase.h Outdated Show resolved Hide resolved
include/triton/Conversion/TritonGPUToLLVM/PatternTritonGPUOpToLLVM.h Outdated Show resolved Hide resolved
@zahimoud
Copy link
Contributor Author

  • Renamed targetInfo.llGetPid() to targetInfo.programId()
  • Moved back PrintOp pattern to nvidia's backend, deleted conversion from amd backend as it's currently not supported

@zahimoud zahimoud merged commit bcb9139 into main Mar 11, 2024
7 checks passed
@zahimoud zahimoud deleted the zahi/split branch March 11, 2024 17:17
htyu pushed a commit to htyu/triton that referenced this pull request Mar 20, 2024
@zahimoud @htyu
[BACKEND] Transformed TritonGPUToLLVMPass to TritonGPUToLLVM in amd b…
fe4da0e 
…ackend (triton-lang#3328)

Changes:

- Extracted SPMD, Print, ControlFlow patterns to separate files
- Deleted TritonGPUToLLVM
- Renamed TritonGPUToLLVMPass to TritonGPUToLLVM
- Extracted ControlFlow, and GetProgramId, FuncOp patterns to common lib
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
@zahimoud
[BACKEND] Transformed TritonGPUToLLVMPass to TritonGPUToLLVM in amd b…
ad1e636 
…ackend (triton-lang#3328)

Changes:

- Extracted SPMD, Print, ControlFlow patterns to separate files
- Deleted TritonGPUToLLVM
- Renamed TritonGPUToLLVMPass to TritonGPUToLLVM
- Extracted ControlFlow, and GetProgramId, FuncOp patterns to common lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux approved these changes

@goostavz goostavz Awaiting requested review from goostavz

@Superjomn Superjomn Awaiting requested review from Superjomn

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zahimoud @ThomasRaoux