[DEBUG] Override fix - Turn FileCacheManager.has_file back into an interface method #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelszczerbuk
changed the title
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…terface method (triton-lang#3336) triton-lang#2934 have changed some of the FileCacheManager methods into a private interface, while `_has_file` method is still being used by the Override functionality. Exposing the method again. (An alternative is to call private `_has_file` from the override, which would be OK too, since it is debug only thing).
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…terface method (triton-lang#3336) triton-lang#2934 have changed some of the FileCacheManager methods into a private interface, while `_has_file` method is still being used by the Override functionality. Exposing the method again. (An alternative is to call private `_has_file` from the override, which would be OK too, since it is debug only thing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2934 have changed some of the FileCacheManager methods into a private interface, while
_has_filemethod is still being used by the Override functionality. Exposing the method again. (An alternative is to call private_has_filefrom the override, which would be OK too, since it is debug only thing).