[AMD backend] fix test_dot_without_load
#3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scxiao
changed the title
test_dot_without_loadtest_dot_without_load
ThomasRaoux
approved these changes
Mar 12, 2024
zhanglx13
approved these changes
Mar 13, 2024
scxiao
force-pushed
the
fix_dot_without_load1
branch
from
cf6614b to
dcb0690
Compare
|
It seems like there is a problem the get the H100 device in the CI build |
joviliast
added a commit
to joviliast/triton
that referenced
this pull request
Mar 13, 2024
TypeConverter: -Support WMMA dot operand type; DecomposeUnsupportedAMDConversions: -Replace `wmma -> dot_op` with `wmma -> blocked -> dot_op`; -Add lit test; RmoveLayoutConversion: -Do not propagate WMMA layout if it is not a chain dot case; WMMA operation convertion: -Fix related to dot operand element size, See also triton-lang#3357 Signed-off-by: joviliast <iveselov.nn@gmail.com>
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
This PR is actually fix the regression in the reverted PR: triton-lang#3338, which caused a regression for the test `test_masked_load_shared_memory`. The reason is for type used in packing dot_op for bfloat16. We should use the type `i16` for `bf16` when packing dot_op for mfma. This time I ran all the tests in `test_core.py` locally, and all work fine.
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
This PR is actually fix the regression in the reverted PR: triton-lang#3338, which caused a regression for the test `test_masked_load_shared_memory`. The reason is for type used in packing dot_op for bfloat16. We should use the type `i16` for `bf16` when packing dot_op for mfma. This time I ran all the tests in `test_core.py` locally, and all work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is actually fix the regression in the reverted PR: #3338, which caused a regression for the test
test_masked_load_shared_memory. The reason is for type used in packing dot_op for bfloat16. We should use the typei16forbf16when packing dot_op for mfma.This time I ran all the tests in
test_core.pylocally, and all work fine.