[FRONTEND] Fix assertion containing incorrect function call in min/max #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokeren
reviewed
Mar 12, 2024
prathams417
force-pushed
the
prathams/fix-min-max-assertion
branch
from
1f8104b to
3f239b3
Compare
Jokeren
changed the title
Jokeren
approved these changes
Mar 12, 2024
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
triton-lang#3358) When running with assertions (`TRITON_DEBUG=1`), there was a compilation issue in the min and max functions in standard.py. Previously, to check whether the datatype was an integer, a function call to `input.dtype.is_integer_type()` was made, but this function call does not exist as a part of dtype. This has now been replaced with the appropriate function call `input.dtype.is_int()`. Co-authored-by: Keren Zhou <kerenzhou@openai.com>
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
triton-lang#3358) When running with assertions (`TRITON_DEBUG=1`), there was a compilation issue in the min and max functions in standard.py. Previously, to check whether the datatype was an integer, a function call to `input.dtype.is_integer_type()` was made, but this function call does not exist as a part of dtype. This has now been replaced with the appropriate function call `input.dtype.is_int()`. Co-authored-by: Keren Zhou <kerenzhou@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with assertions (
TRITON_DEBUG=1), there was a compilation issue in the min and max functions in standard.py. Previously, to check whether the datatype was an integer, a function call toinput.dtype.is_integer_type()was made, but this function call does not exist as a part of dtype. This has now been replaced with the appropriate function callinput.dtype.is_int().