Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Fix heap-use-after-free in createAsyncCopy #3365

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[BACKEND] Fix heap-use-after-free in createAsyncCopy #3365

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3293c
move erase out of the for loop
khasanovaa Mar 13, 2024
0e24bd0
follow MLIR stlye
khasanovaa Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/Dialect/TritonGPU/Transforms/Pipeliner/MatmulLoopPipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,16 @@ createAsyncCopy(scf::ForOp &forOp, tt::LoadOp loadOp, Value alloc,
alloc.replaceAllUsesWith(viewLoad.getResult());
alloc.erase();
} else {
SmallVector<ttg::LocalAllocOp> allocs_to_erase;
khasanovaa marked this conversation as resolved.
Show resolved Hide resolved
for (Operation *user : loadOp->getUsers()) {
if (auto alloc = dyn_cast<ttg::LocalAllocOp>(user)) {
alloc.replaceAllUsesWith(viewLoad.getResult());
alloc.erase();
allocs_to_erase.push_back(alloc);
}
}
for (auto alloc : allocs_to_erase) {
alloc.erase();
}
auto sharedLoad =
builder.create<ttg::LocalLoadOp>(loc, loadOp.getType(), viewLoad);
loadOp->replaceAllUsesWith(sharedLoad->getResults());
Expand Down
Loading