[TESTS] Rewrite test_conversions to only use portable code #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…ng#3368) Removing ptx inline assembly from test_conversions.py. Using method proposed by Adam Goucher to perform the RTNE rounding instead: Add the 0x800000 (8388608) to bring the value to the range [2 ** 23, 2 ** 24], where floats correspond with integers. Also, this utilizes the default RTNE rounding of addition. Then subtract 0x800000 to bring the value to the original range, already rounded to integer. Finally, do a simple fp to int cast.
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…ng#3368) Removing ptx inline assembly from test_conversions.py. Using method proposed by Adam Goucher to perform the RTNE rounding instead: Add the 0x800000 (8388608) to bring the value to the range [2 ** 23, 2 ** 24], where floats correspond with integers. Also, this utilizes the default RTNE rounding of addition. Then subtract 0x800000 to bring the value to the original range, already rounded to integer. Finally, do a simple fp to int cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing ptx inline assembly from test_conversions.py. Using method proposed by Adam Goucher to perform the RTNE rounding instead:
Add the 0x800000 (8388608) to bring the value to the range [2 ** 23, 2 ** 24], where floats correspond with integers. Also, this utilizes the default RTNE rounding of addition. Then subtract 0x800000 to bring the value to the original range, already rounded to integer. Finally, do a simple fp to int cast.