[AMD] Map PreciseSqrtOp and PreciseDivFOp to LLVM instructions #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayfurmanek
changed the title
zahimoud
approved these changes
Mar 13, 2024
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
…n-lang#3369) Here we map PreciseSqrtOp and PreciseDivOp to LLVM instructions for the AMD backend. These "Precise" ops are currently defined as round-to-nearest-even which is the default rounding mode in the LLVM instructions for the AMD backend. Alternatively we could call into the AMD `ocml.bc`. This works for sqrt but `__ocml_div_{rm}_f32` is currently unimplemented. If further "Precise" math ops are added with different rounding modes or otherwise don't map to LLVM ops, we can revisit this.
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…n-lang#3369) Here we map PreciseSqrtOp and PreciseDivOp to LLVM instructions for the AMD backend. These "Precise" ops are currently defined as round-to-nearest-even which is the default rounding mode in the LLVM instructions for the AMD backend. Alternatively we could call into the AMD `ocml.bc`. This works for sqrt but `__ocml_div_{rm}_f32` is currently unimplemented. If further "Precise" math ops are added with different rounding modes or otherwise don't map to LLVM ops, we can revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we map PreciseSqrtOp and PreciseDivOp to LLVM instructions for the AMD backend.
These "Precise" ops are currently defined as round-to-nearest-even which is the default rounding mode in the LLVM instructions for the AMD backend.
Alternatively we could call into the AMD
ocml.bc. This works for sqrt but__ocml_div_{rm}_f32is currently unimplemented.If further "Precise" math ops are added with different rounding modes or otherwise don't map to LLVM ops, we can revisit this.