[BACKEND] Tweak convert_layout backward propagation #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some extra heuristic to the convert layout backward propagation to consider convet_layout that are known to be no-ops. In this kind of cases we want to make sure we don't assume that folding it with another convert would be free.
jlebar
approved these changes
Mar 15, 2024
test/TritonGPU/combine.mlir
Outdated
|
|
||
| module attributes {"triton_gpu.num-ctas" = 1 : i32, "triton_gpu.num-warps" = 8 : i32, "triton_gpu.threads-per-warp" = 32 : i32} { | ||
| // Verify that we don't hoist the convert on top of the broadcast. In general we should hoist the convert to reduce its cost | ||
| // but because this would make use combine the 1st and second convert and the 1st convert is known to be a no-op this would |
There was a problem hiding this comment.
s/make use combine/combine/?
zahimoud
approved these changes
Mar 15, 2024
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
Add some extra heuristic to the convert layout backward propagation to consider convet_layout that are known to be no-ops. In this kind of cases we want to make sure we don't assume that folding it with another convert would be free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some extra heuristic to the convert layout backward propagation to consider convet_layout that are known to be no-ops. In this kind of cases we want to make sure we don't assume that folding it with another convert would be free.