[SETUP] Set max timeout when downloading nvidia dependencies #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhat-nguyen
changed the title
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…lang#3414) We have experienced intermittent forever hangs during triton installation, specifically when downloading the nvidia dependencies. This developer has found that `request.urlopen` not having a set timeout can potentially lead to this issue: mesonbuild/meson#4087 I have set the timeout to 5 minutes which should be enough to download each individual dependency while also preventing the forever hang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have experienced intermittent forever hangs during triton installation, specifically when downloading the nvidia dependencies. This developer has found that
request.urlopennot having a set timeout can potentially lead to this issue: mesonbuild/meson#4087I have set the timeout to 5 minutes which should be enough to download each individual dependency while also preventing the forever hang.