[FRONTEND] Fix broadcasting of tl.math.div_rn
#3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`binary_op_type_legalization` does broadcasting, we just need to use the results.
jlebar
approved these changes
Mar 19, 2024
auto-merge was automatically disabled
March 20, 2024 17:07
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
March 20, 2024 18:45
Head branch was pushed to by a user without write access
Jokeren
reviewed
Mar 20, 2024
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
`binary_op_type_legalization` does broadcasting, we just need to use the results. I also improve `_test_binary` to check both the left and right argument can be broadcasted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary_op_type_legalizationdoes broadcasting, we just need to use the results.I also improve
_test_binaryto check both the left and right argument can be broadcasted.