Revert "[FRONTEND] Emit NegFOp for unary minus operator (#3394)" #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasRaoux
requested review from
jlebar and
ptillet
and removed request for
ptillet
ptillet
approved these changes
Mar 19, 2024
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
…3394)" (triton-lang#3420) This reverts commit b513a8a. This causes a failure in one of our internal test (it seems like this change the numeric precision even though I don't think it should). It will be investigated next week as OAI is on a break this week. Sorry for the inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 235d5d8.
This causes a failure in one of our internal test (it seems like this change the numeric precision even though I don't think it should). It will be investigated next week as OAI is on a break this week.
Sorry for the inconvenience.